[FEATURE REQUEST] Allow passcode and pattern screens in landscape mode#4871
[FEATURE REQUEST] Allow passcode and pattern screens in landscape mode#4871joragua wants to merge 4 commits into
Conversation
joragua
force-pushed
the
feature/passcode_and_pattern_in_landscape
branch
3 times, most recently
from
1d70daa to
6c990bc
Compare
joragua
force-pushed
the
feature/passcode_and_pattern_in_landscape
branch
from
6c990bc to
0cb53a7
Compare
| android:orientation="vertical" | ||
| app:layout_constraintGuide_percent="0.35" /> | ||
|
|
||
| </androidx.constraintlayout.widget.ConstraintLayout> |
There was a problem hiding this comment.
Extensible to the complete PR:
Files referring passcode called passcodelock
Files referring pattern called activity_pattern_lock
Shouldn't they follow the same name convention? (that's a regression, not from this PR, but i had to comment it 😄 )
| android:layout_height="wrap_content" | ||
| android:layout_marginTop="@dimen/standard_margin" | ||
| android:gravity="center" | ||
| android:text="@string/pass_code_enter_pass_code" |
There was a problem hiding this comment.
The string refers to passcode, and this layout is for pattern. Is that incorrect?
| android:filterTouchesWhenObscured="true"> | ||
|
|
||
| <TextView | ||
| android:id="@+id/header" |
There was a problem hiding this comment.
This sounds not very descriptive. I'd set something like passcode_header or similar
| android:filterTouchesWhenObscured="true"> | ||
|
|
||
| <TextView | ||
| android:id="@+id/header" |
| app:layout_constraintTop_toTopOf="parent"/> | ||
|
|
||
| <TextView | ||
| android:id="@+id/explanation" |
There was a problem hiding this comment.
I'd set a more descriptive name as well
| app:layout_constraintTop_toBottomOf="@id/error" /> | ||
|
|
||
| <com.owncloud.android.presentation.security.passcode.NumberKeyboard | ||
| android:id="@+id/numberKeyboard" |
There was a problem hiding this comment.
ids are snakecase in other layouts
| </LinearLayout> | ||
|
|
||
| <TextView | ||
| android:id="@+id/error" |
There was a problem hiding this comment.
I'd rename as error_passcode because in pattern the id is error_pattern
| </LinearLayout> | ||
|
|
||
| <TextView | ||
| android:id="@+id/error" |
There was a problem hiding this comment.
I'd rename as error_passcode because in pattern the id is error_pattern
| android:layout_height="wrap_content" | ||
| android:orientation="vertical" | ||
| app:layout_constraintGuide_percent="0.25" /> | ||
| app:layout_constraintGuide_percent="0.3" /> |
There was a problem hiding this comment.
Question: this tiny change (0.25 -> 0.3) is really meaningful? why?
| android:layout_height="wrap_content" | ||
| android:orientation="vertical" | ||
| app:layout_constraintGuide_percent="0.75" /> | ||
| app:layout_constraintGuide_percent="0.7" /> |
There was a problem hiding this comment.
Same question as above: this tiny change (0.75 -> 0.7) is really meaningful? why?
2 participants
Related Issues
App: -
Starting from Android 16, Android will ignore resizability and orientation restrictions for large screen devices, such as foldables and tablets. That means that the
android: screenOrientationconfiguration in the manifest will be ignored, and screens using that configuration should support both orientations (portrait and landscape). In our case, we have two screens affected by this restriction: passcode and pattern screensWork done:
Passcode
w600dpwithsw600dpin order to use the layout-land for phones in landscapePattern
w600dpwithsw600dpin order to use the layout-land for phones in landscapeReleaseNotesViewModel.ktcreating a newReleaseNote()with String resources (if required)QA